-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add WixToolset (and Bash for Windows recommendation) to Windows setup #13567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo, see our faq https://devdocs.jabref.org/code-howtos/faq.html#fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was sloppy of me. I will undo and be more careful in the future.
You committed your code on the For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details. |
It's taking me a few attempts to fix the submodules issue. Please don't rereview. I apologize. |
Your pull request modified git submodules. Please follow our FAQ on submodules to fix. |
Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes. At the end, all commits will be squashed anyway before being merged into the In future, please avoid that. For now, you can continue working. |
I replaced this PR with #13568 Sorry for the extra work. |
@trag-bot didn't find any issues in the code! ✅✨ |
1 similar comment
@trag-bot didn't find any issues in the code! ✅✨ |
I read more of your guide and see that I shouldn't have created a new PR (which I have now closed) and created another. I have reopened this and will fix it here. Sorry for the bad technique. |
No worries 😅. All projects treat things differently 😅. Lookinbg forward! |
Closes JabRef/user-documentation#578
Related to JabRef/user-documentation#579
I recommend Git for Windows because (1) it is installed with Git Bash and (2) it is commonly used by Windows developers to have a linux-like environment. This generally eliminates the need for separate Windows build instructions. I realize this is kind of pushy so would be happy to remove it from this PR and/or create an issue.
Steps to test
n/a
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)