-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multiround benchmarking & enhance LLMService
interfaces
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix custom error classes declarations
Note: it made possible to correctly extract proof generation metadata
Also: improve tests' code, fix `expect(...).toBeRejected()` not being awaited bug
(after comprehensive manual testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Changes ⚡️
Multiround Benchmarking Support 🥊
Now it is possible to benchmark multiround proof generation, as is our tradition, with comprehensive error handling and logging.
LLMService
Interface Rework 🕊ProofGenerationMetadataHolder
object, enabling the collection of additional metadata.LLMService
constructors for cleaner implementations.GeneratedProof
to store raw proof metadata (e.g., statistics returned by theLLMService
generation method), facilitating detailed proof analysis—especially useful for benchmarks.Changes to the
llm
module are thoroughly covered by tests, while the new benchmarking features have been extensively tested manually.Additional Value 🌟
Enhanced benchmarking result interfaces: redesigned with improved typing for safer and more convenient usage.
Custom errors: introduced specific error types (
IllegalStateError
,InvariantFailedError
,BenchmarkingError
) with wrappers, replacing genericthrow Error
cases. Refactored the benchmarking module accordingly and ensured custom error declarations are reliable.Stricter and clearer error handling: strengthened and documented error handling in the benchmarking framework.
Utility code improvements: got rid of duplicated utilities, introduced better typings (e.g., for theorem rankers, colorization, LLM iterator).
Bug Fixes
OpenAIService
.