Minor LLMService defaults update, mark TODOs

src/llm/llmServices/commonStructures/proofGenerationMetadata.ts

@@ -33,6 +33,7 @@ interface FailureMetadata {
     llmServiceError: LLMServiceError;
 }
 
+// TODO: document, especially its invariant to be used only once
 export class ProofGenerationMetadataHolder {
     private _configuration: ConfigurationMetadata | undefined = undefined;
     private _success: SuccessMetadata | undefined = undefined;
@@ -121,10 +122,11 @@ export class ProofGenerationMetadataHolder {
         currentValue: any | undefined,
         propertyName: string
     ) {
-        if (currentValue === undefined) {
+        if (currentValue !== undefined) {
             illegalState(
-                `\`ProofGenerationMetadata\` should be updated with ${propertyName} `,
-                "only once by the `LLMService` internals"
+                `\`ProofGenerationMetadata\` is updated with ${propertyName} more than once;\n`,
+                "Possible reasone: the same `ProofGenerationMetadata` should not be used ",
+                "more than for one proof generation"
             );
         }
     }

src/llm/llmServices/llmService.ts

@@ -128,7 +128,7 @@ export abstract class LLMServiceImpl<
      * @param generationLogsFilePath if it is not specified, a temporary file will be used.
      */
     constructor(
-        eventLogger: EventLogger | undefined,
+        eventLogger: EventLogger | undefined = undefined,
         errorsHandlingMode: ErrorsHandlingMode = ErrorsHandlingMode.RETHROW_ERRORS,
         generationLogsFilePath: string | undefined = undefined,
         debugLogs: boolean = false

src/llm/llmServices/utils/generationsLogger/loggerRecord.ts

@@ -21,6 +21,7 @@ export class ParsingError extends Error {
     }
 }
 
+// TODO: support `proofGenerationType` if ever needed
 export class LoggerRecord {
     /**
      * Even though this value is in millis, effectively it represents seconds.