Skip to content

Conversation

vaibhavrajsingh2001
Copy link
Contributor

@vaibhavrajsingh2001 vaibhavrajsingh2001 commented Sep 24, 2024

Summary

Use our own @kong/httpsnippet package instead of the forked httpsnippet-lite package.

@vaibhavrajsingh2001 vaibhavrajsingh2001 self-assigned this Sep 24, 2024
@jackkav
Copy link

jackkav commented Sep 25, 2024

If theres any compatibility issues with this repo, theres an open PR to upstream httpsnippet-lite improvements into kong/httpsnippet Kong/httpsnippet#359

@vaibhavrajsingh2001
Copy link
Contributor Author

If theres any compatibility issues with this repo, theres an open PR to upstream httpsnippet-lite improvements into kong/httpsnippet Kong/httpsnippet#359

Hey @jackkav the only issues we're facing with @kong/httpsnippet is its usage of ajv.
I've started a thread in #ask-insomnia to talk about it.
I'll cc you on it.

@vaibhavrajsingh2001 vaibhavrajsingh2001 force-pushed the feat--kong-http-snippet-KHCP-13130 branch from 02bf9a1 to 84b6fb9 Compare October 1, 2024 10:13
@vaibhavrajsingh2001 vaibhavrajsingh2001 marked this pull request as ready for review October 1, 2024 10:27
@vaibhavrajsingh2001 vaibhavrajsingh2001 changed the title feat: replace httpsnippet-lite with kong/httpsnippet package [KHCP-13130] feat: use @kong/httpsnippet package for snippet generation [KHCP-13130] Oct 1, 2024
@vaibhavrajsingh2001 vaibhavrajsingh2001 merged commit fd5a681 into main Oct 2, 2024
3 checks passed
@vaibhavrajsingh2001 vaibhavrajsingh2001 deleted the feat--kong-http-snippet-KHCP-13130 branch October 2, 2024 14:02
kongponents-bot pushed a commit that referenced this pull request Oct 2, 2024
# [1.78.0](v1.77.1...v1.78.0) (2024-10-02)

### Features

* use @kong/httpsnippet package for snippet generation [KHCP-13130] ([#332](#332)) ([fd5a681](fd5a681))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.78.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Install the preview package from this PR

@kong/spec-renderer-dev@pr-332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants