Skip to content

feat: use @kong/httpsnippet package for snippet generation [KHCP-13130] #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: use @kong/httpsnippet package for snippet generation [KHCP-13130] #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fde9bc1
feat: add httpsnippet with pinned ajv dependency
vaibhavrajsingh2001 Sep 24, 2024
57b21cd
feat(vite-config): add querystring node polyfill
vaibhavrajsingh2001 Sep 24, 2024
66c1756
chore: replace httpsnippet-lite imports with httpsnippet
vaibhavrajsingh2001 Sep 24, 2024
84b6fb9
chore: bump httpsnippet package version
vaibhavrajsingh2001 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@vueuse/core": "^11.1.0",
"allof-merge": "^0.6.6",
"flatted": "^3.3.1",
"httpsnippet-lite": "^3.0.5",
"httpsnippet": "^3.0.7",
"json-schema": "^0.4.0",
"markdown-it": "^14.1.0",
"oas-normalize": "^11.1.2",
Expand Down
104 changes: 68 additions & 36 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/components/spec-document/samples/RequestSample.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@
import { watch, ref, computed, inject } from 'vue'
import type { PropType, Ref } from 'vue'
import type { IHttpOperation, INodeExample } from '@stoplight/types'
import { HTTPSnippet } from 'httpsnippet-lite'
import { HTTPSnippet } from 'httpsnippet'
import { requestSampleConfigs } from '@/constants'
import { getRequestHeaders } from '@/utils'
import CodeBlock from '@/components/common/CodeBlock.vue'
import CollapsablePanel from '@/components/common/CollapsablePanel.vue'
import type { LanguageCode } from '@/types/request-languages'
import type { HarRequest, HTTPSnippet as HTTPSnippetType, TargetId } from 'httpsnippet-lite'
import type { HarRequest, HTTPSnippet as HTTPSnippetType, TargetId } from 'httpsnippet'
import SelectDropdown from '@/components/common/SelectDropdown.vue'
import LanguageIcon from '@/components/common/LanguageIcon.vue'
import type { SelectItem } from '@/types'
Expand Down Expand Up @@ -243,7 +243,7 @@ watch(() => ({
requestQuery: props.requestQuery,
authQuery: props.authQuery,
requestBody: props.requestBody,
}), async (newValue, oldValue) => {
}), (newValue, oldValue) => {

if (newValue.method !== oldValue?.method && requestConfigs.value?.[0]) {
selectedLang.value = requestConfigs.value[0].httpSnippetLanguage
Expand Down Expand Up @@ -308,7 +308,7 @@ watch(() => ({
requestCode.value = newValue.requestBody
return requestSampleConfigs.filter(c => c.httpSnippetLanguage !== 'json')
} else if (snippet.value) {
requestCode.value = await snippet.value.convert((newValue.lang as TargetId), newValue.lib)
requestCode.value = snippet.value.convert((newValue.lang as TargetId), newValue.lib) || ''
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/types/request-languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { TargetId, ClientId } from 'httpsnippet-lite'
import type { TargetId, ClientId } from 'httpsnippet'
export type LanguageCode = TargetId | 'json'
interface LibraryConfig {
label: string
Expand Down
2 changes: 1 addition & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default defineConfig({
* during the build
*/
nodePolyfills({
include: ['util', 'path'],
include: ['util', 'path', 'querystring'],
}),
vue({
features: {
Expand Down