Update cache dependency paths in CI workflow#213
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
hey @mubking, this is a duplicate of #212 — same change, same issue.
the cache-dependency-path should point to the lock file (package-lock.json), not package.json. changing it to package.json is the wrong fix.
the correct approach:
- make sure
frontend/package-lock.jsonandbackend/package-lock.jsonexist (runnpm installin each directory) - commit those lock files
- revert
cache-dependency-pathback to pointing at the lock files
please close this PR and the other duplicates (#212, #214) and open one clean PR with the right fix. happy to review it quickly!
also come chat with us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
|
closing this PR — it's been open since March without activity and has failing CI from a stale base. the codebase has moved on significantly since this was opened. if the changes here are still relevant, please open a fresh PR against current main. join us on Telegram if you want to coordinate: https://t.me/+DOylgFv1jyJlNzM0 |
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes