Skip to content

Conversation

@M-Colley
Copy link
Owner

Summary

  • add opt-in package loader, clipboard-safe utilities, and effect-size reporting for NPAV variants
  • create a comprehensive testthat suite covering every helper plus supporting helpers for sourcing
  • add a GitHub Actions workflow that installs required R packages and runs the tests on every push/PR

Testing

  • Not run (R is not available in the execution environment)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +15 to +20
- name: Install dependencies
run: |
install.packages(c(
"testthat", "tidyverse", "rstatix", "ggstatsplot", "ggsignif",
"see", "ggpmisc", "writexl", "readxl", "emoa", "effectsize"
))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Run dependency install step inside R

The workflow step that is supposed to install the R packages (lines 15‑20) runs install.packages(...) as a plain shell command. GitHub Actions steps default to bash, so the runner throws install.packages: command not found before any dependencies are installed or tests run. Wrap the installation in an R invocation (e.g. Rscript -e 'install.packages(...)' or shell: Rscript {0}) so the command executes inside R and the job can proceed.

Useful? React with 👍 / 👎.

Comment on lines +17 to +20
install.packages(c(
"testthat", "tidyverse", "rstatix", "ggstatsplot", "ggsignif",
"see", "ggpmisc", "writexl", "readxl", "emoa", "effectsize"
))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Workflow omits easystats required during tests

In the helper (tests/testthat/helper-r_code.R:2) the tests disable automatic installation, yet r_functionality.R still executes library(easystats) (line 57). The workflow’s dependency list (lines 17‑20) never installs easystats, so sourcing the file immediately errors with “there is no package called ‘easystats’” and the suite never runs. Ensure that easystats (and any other packages loaded unconditionally) are installed in this step before sourcing the script, or stop disabling auto installs for the workflow.

Useful? React with 👍 / 👎.

@M-Colley M-Colley deleted the codex/add-tests-and-effect-sizes-validation branch November 23, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants