- 
                Notifications
    You must be signed in to change notification settings 
- Fork 24
Split PR #167 into wave module changes #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split PR #167 into wave module changes #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simmsa The PR looks good to me after review. I made minor modifications to some of the examples—if everything looks good on your end, feel free to go ahead and merge it.
| @MShabara sounds good! Thank you for taking a look. I just need to update the changelog and then I will merge this. | 
These changes are more complex than anticipated and need to be moved to a new branch and PR.
f58ae31    to
    6dc9b36      
    Compare
  
    
This PR takes the wave module code from PR #167 but specifically excludes short_term_extreme.m changes which are failing tests and require additional effort.
List of changes:
examplesfrom input file pathexamplesfrom input file path