Report heap metrics from clusterd #33686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
heap-metrics
branch
12 times, most recently
from
8850a63 to
1519e89
Compare
5 tasks
teskje
force-pushed
the
heap-metrics
branch
4 times, most recently
from
65e8c30 to
0ddc09e
Compare
teskje
commented
Oct 1, 2025
src/clusterd/src/usage_metrics.rs
Outdated
|
|
||
| let mut memory = None; | ||
| let mut swap = None; | ||
| for line in meminfo.lines() { |
Contributor
Author
There was a problem hiding this comment.
Do something like ProcStatus for parsing here.
teskje
commented
Oct 1, 2025
| SqlScalarType::TimestampTz { precision: None }.nullable(false), | ||
| ) | ||
| .with_column("heap_bytes", SqlScalarType::UInt64.nullable(true)) | ||
| .with_column("heap_limit", SqlScalarType::UInt64.nullable(true)) |
Contributor
Author
There was a problem hiding this comment.
Add comment: Fields only at the end + nullable
This commit extends the usage metrics provided by clusterd's `/api/usage-metrics` endpoint with the memory usage, as well as the effective heap (memory+swap) limit. As for the existing usage collection, we mainly focus on Linux support, for macOS we only provide the required stubs to make sure the code compiles and run.
This change makes the kubernetes orchestrator collect the new heap metrics reported by clusterd processes and report them to the controller, where they are added to the `mz_cluster_replica_metrics_history` relation.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the usage metrics reporting in clusterd to also report the current memory usage and heap limit. environmentd then makes use of the new information to populate two new columns in
mz_cluster_replica_metrics_history:heap_bytesandheap_limit. The new columns will be useful in implementing the new "Memory Utilization" UI in the Console, especially in self-managed environments.Motivation
Closes https://github.com/MaterializeInc/database-issues/issues/9692
Tips for reviewer
Thanks to #33720, we won't be losing any data already in
mz_cluster_replica_metrics_historyby making this change. The new columns will have NULL for old measurements instead.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.