Catalog: add migration for mock_authentication_nonce setting #33691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAlperin
force-pushed
the
dov/migrate-mock-nonce
branch
3 times, most recently
from
db4d6c3 to
78d1f22
Compare
SangJunBak
requested changes
Sep 23, 2025
5 tasks
The [SASL/SCRAM](MaterializeInc#33468) PR introduces the need for some stable, cluster wide, cryptographically random key material. We use this material to be able to present deterministic challenges for even users that don't exist to guard against enumeration attacks. However that PR made a bad assumption that the initialize step of catalog opening would always add this new key. But old versions that have already been initialized wouldn't have it! This PR add code to generate it for old versions
DAlperin
force-pushed
the
dov/migrate-mock-nonce
branch
from
78d1f22 to
fc09ad9
Compare
SangJunBak
approved these changes
Sep 25, 2025
Member
Author
|
TYFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SASL/SCRAM
PR introduces the need for some stable, cluster wide, cryptographically
random key material. We use this material to be able to present
deterministic challenges for even users that don't exist to guard
against enumeration attacks.
However that PR made a bad assumption that the initialize step of
catalog opening would always add this new key. But old versions that
have already been initialized wouldn't have it! This PR add code to
generate it for old versions
Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/9724
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.