Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the outdated ACCEL_CURVE analyzer option from both front-end and back-end codebases, along with its associated configuration and assets.
Changes:
- Removed ACCEL_CURVE enum value from both TypeScript and Java AnalyzerType definitions
- Removed ACCEL_CURVE configuration block from AnalyzerTypes.ts including its description, image reference, and links
- Removed accelImage import from assets/help/index.ts
- Removed SHIFT_CURVE enum value from backend Java AnalyzerType
- Swapped axis order in the "Shift Curve" preset from [RPM PRIM, RPM SEC] to [RPM SEC, RPM PRIM]
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| front-end/src/types/ApiTypes.ts | Removed ACCEL_CURVE from AnalyzerType enum |
| front-end/src/types/AnalyzerTypes.ts | Removed ACCEL_CURVE configuration block and related imports (accelImage, interpolateImage) |
| front-end/src/lib/subteamGraphPresets.ts | Swapped axes order in "Shift Curve" preset |
| front-end/src/assets/help/index.ts | Removed accelImage import and export |
| backend/src/main/java/com/mcmasterbaja/model/AnalyzerType.java | Removed ACCEL_CURVE and SHIFT_CURVE enum values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,3 @@ | |||
| import accelImage from '@assets/help/accel.png'; | |||
| import interpolateImage from '@assets/help/interpolate.png'; | |||
There was a problem hiding this comment.
The image file accel.png is no longer imported or used after removing the ACCEL_CURVE analyzer configuration. This file should be deleted from the repository to avoid accumulating unused assets.
| axes: [ | ||
| { source: 'RPM PRIM.csv', dataType: 'RPM PRIM' }, | ||
| { source: 'RPM SEC.csv', dataType: 'RPM SEC' }, | ||
| { source: 'RPM PRIM.csv', dataType: 'RPM PRIM' }, |
There was a problem hiding this comment.
The axes have been swapped in a way that contradicts the description. The description states "Secondary RPM vs Primary RPM", which means Secondary RPM (Y-axis) should be plotted against Primary RPM (X-axis). Based on the pattern used in other presets (e.g., "Vehicle speed vs Timestamp" where Timestamp is first and speed is second), the axes should be ordered as [RPM PRIM, RPM SEC] (Primary first as X-axis, Secondary second as Y-axis). The current order [RPM SEC, RPM PRIM] produces the opposite: Primary vs Secondary.
| { source: 'RPM SEC.csv', dataType: 'RPM SEC' }, | |
| { source: 'RPM PRIM.csv', dataType: 'RPM PRIM' }, | |
| { source: 'RPM PRIM.csv', dataType: 'RPM PRIM' }, | |
| { source: 'RPM SEC.csv', dataType: 'RPM SEC' }, |
No description provided.