Skip to content

340 remove outdated accel curve option #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hydrowoxy wants to merge 4 commits into from
Closed

340 remove outdated accel curve option #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4037d20
removed accel curve from front end and backend enum
hydrowoxy Jan 14, 2026
7365c9f
remove shift curve from enum
hydrowoxy Jan 14, 2026
94df752
remove redundant images
hydrowoxy Jan 14, 2026
95e35c6
fix shift curve
hydrowoxy Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions backend/src/main/java/com/mcmasterbaja/model/AnalyzerType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.mcmasterbaja.model;

public enum AnalyzerType {
ACCEL_CURVE,
AVERAGE,
CUBIC,
DELETE_OUTLIER,
Expand All @@ -13,7 +12,6 @@ public enum AnalyzerType {
SPLIT,
CONSTANT_ADDER,
STRICT_TIMESTAMP,
SHIFT_CURVE,
SMOOTH_STRICT_PRIM,
SMOOTH_STRICT_SEC;

Expand Down
2 changes: 0 additions & 2 deletions front-end/src/assets/help/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import accelImage from '@assets/help/accel.png';
import interpolateImage from '@assets/help/interpolate.png';
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image file accel.png is no longer imported or used after removing the ACCEL_CURVE analyzer configuration. This file should be deleted from the repository to avoid accumulating unused assets.

Copilot uses AI. Check for mistakes.
import linearMultiplierImage from '@assets/help/linMult.png';
import RdpGif from '@assets/help/rdp.gif';
Expand All @@ -9,7 +8,6 @@ import splitImage from '@assets/help/split.png';
import placeholderImage from '@assets/help/placeholder.png';

export {
accelImage,
interpolateImage,
linearMultiplierImage,
RdpGif,
Expand Down
2 changes: 1 addition & 1 deletion front-end/src/lib/subteamGraphPresets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export const subteamGraphPresets: DataViewerPreset[] = [
graphs: [
{
axes: [
{ source: 'RPM PRIM.csv', dataType: 'RPM PRIM' },
{ source: 'RPM SEC.csv', dataType: 'RPM SEC' },
{ source: 'RPM PRIM.csv', dataType: 'RPM PRIM' },
Comment on lines 10 to +11
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The axes have been swapped in a way that contradicts the description. The description states "Secondary RPM vs Primary RPM", which means Secondary RPM (Y-axis) should be plotted against Primary RPM (X-axis). Based on the pattern used in other presets (e.g., "Vehicle speed vs Timestamp" where Timestamp is first and speed is second), the axes should be ordered as [RPM PRIM, RPM SEC] (Primary first as X-axis, Secondary second as Y-axis). The current order [RPM SEC, RPM PRIM] produces the opposite: Primary vs Secondary.

Suggested change
{ source: 'RPM SEC.csv', dataType: 'RPM SEC' },
{ source: 'RPM PRIM.csv', dataType: 'RPM PRIM' },
{ source: 'RPM PRIM.csv', dataType: 'RPM PRIM' },
{ source: 'RPM SEC.csv', dataType: 'RPM SEC' },

Copilot uses AI. Check for mistakes.
],
analyzer: AnalyzerType.SGOLAY,
analyzerOptions: ['100', '3'],
Expand Down
14 changes: 0 additions & 14 deletions front-end/src/types/AnalyzerTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
/* eslint-disable max-len */
import { AnalyzerType } from '@types';
import {
accelImage,
interpolateImage,
linearMultiplierImage,
RdpGif,
rollAvgImage,
Expand Down Expand Up @@ -47,18 +45,6 @@ export const analyzerConfig: Record<AnalyzerKey, AnalyzerConfigItem> = {
defaultChecked: true,
},

[AnalyzerType.ACCEL_CURVE]: {
title: 'Acceleration Curve Tool',
description:
'Given both primary (y-axis) and secondary (x-axis) RPM values, applies noise reduction then interpolates to show the shift curve.',
isJoinBased: true,
image: {
src: accelImage,
alt: 'Acceleration curve demo',
},
links: [{ title: 'CVT Shifting Stages', url: 'CVT_Tutorial-part-2.pdf' }],
},

[AnalyzerType.SGOLAY]: {
title: 'Savitzky-Golay Smoother',
description:
Expand Down
1 change: 0 additions & 1 deletion front-end/src/types/ApiTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export interface MinMax {
}

export enum AnalyzerType {
ACCEL_CURVE = 'ACCEL_CURVE',
AVERAGE = 'AVERAGE',
CUBIC = 'CUBIC',
LINEAR_MULTIPLY = 'LINEAR_MULTIPLY',
Expand Down
Loading