Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufr2ioda python tool for satwnd in bufr format (non-prepbufr) #279

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

HuiLiu-NOAA
Copy link
Collaborator

@HuiLiu-NOAA HuiLiu-NOAA commented Feb 13, 2025

This PR adds a python converter for RAP GOES (types 245-247) bufr satwnd format to ioda files. The new variables of prepbufr Report types, initial ObsError and QualityMarker are added in this set of IODA files for convenience. These output IODA files are being used in testing of GOES AMV assimilation with MPAS-JEDI for RRFSv2.

ioda_satwnd_dc

@HuiLiu-NOAA HuiLiu-NOAA self-assigned this Feb 13, 2025
@HuiLiu-NOAA HuiLiu-NOAA changed the title Add bufr2ioda python tool for satwnd in bufr format (non prepbufr) Add bufr2ioda python tool for satwnd in bufr format (non-prepbufr) Feb 13, 2025
@SamuelDegelia-NOAA
Copy link
Contributor

@HuiLiu-NOAA The converter looks good to me! My only comment is whether it possible to modify the directory and datetime variables in bufr2ioda_satwnd.json so that we can run the converter using our existing rrfs-test/IODA/python/run_bufr2ioda.sh script? See this code for example: https://github.com/NOAA-EMC/RDASApp/blob/develop/rrfs-test/IODA/python/bufr2ioda_nexrad.json

Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuiLiu-NOAA
Copy link
Collaborator Author

@SamuelDegelia-NOAA : Should we update the ioda_satwnd.nc etc in the expr_data/ as well?

@SamuelDegelia-NOAA
Copy link
Contributor

@HuiLiu-NOAA Can do - please provide a path to the new file and I will stage it in RDAS_DATA.

@HuiLiu-NOAA
Copy link
Collaborator Author

@HuiLiu-NOAA Can do - please provide a path to the new file and I will stage it in RDAS_DATA.

Here it is. Hera: /home/Hui.Liu/codekeep/PR_satwnd/

@SamuelDegelia-NOAA
Copy link
Contributor

@HuiLiu-NOAA Can do - please provide a path to the new file and I will stage it in RDAS_DATA.

Here it is. Hera: /home/Hui.Liu/codekeep/PR_satwnd/

Done! The new files are staged on hera, jet, and orion/hercules.

@ShunLiu-NOAA ShunLiu-NOAA merged commit dac832e into develop Feb 13, 2025
3 checks passed
@ShunLiu-NOAA ShunLiu-NOAA deleted the feature/bufr2ioda-for-satwnd branch February 13, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants