feat: add reasoning trace extraction from llm calls #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 2, 2025
tgasser-nv
approved these changes
Oct 3, 2025
| ): # Exclude content since it may be modified by rails | ||
| metadata[field_name] = getattr(response, field_name) | ||
| llm_response_metadata_var.set(metadata) | ||
|
|
There was a problem hiding this comment.
I'm not sure I understand if you're refactoring here to clean things up, shouldn't we call _store_reasoning_trace() to maintain the same functionality ?
| return None | ||
|
|
||
|
|
||
| def extract_bot_thinking_from_events(events: list): |
There was a problem hiding this comment.
nit: Should this be called 'extract_first_bot_thinking_from_events()' or similar? If the events are ordered with the newest at the start of the list this returns the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack Info
This PR is part of a stack:
Description
add reasoning trace extraction from llm calls as we are using invoke and ainvoke in llm_call