feat: emit BotThinking events with reasoning traces #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts reasoning traces from LLM responses and emits BotThinking events before BotMessage events. Adds bot_thinking_content to context for use in output rails.
Pouyanpi
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Oct 2, 2025
tgasser-nv
approved these changes
Oct 6, 2025
| context={ | ||
| "user_input": user_input, | ||
| "bot_response": bot_response, | ||
| "bot_thinking": bot_thinking, |
There was a problem hiding this comment.
Are there any issues if we don't use a reasoning model and bot_thinking is empty?
| @@ -0,0 +1,42 @@ | |||
| prompts: | |||
There was a problem hiding this comment.
Would a better config name be self_check_thinking instead?
| @@ -0,0 +1,42 @@ | |||
| prompts: | |||
| - task: self_check_input | |||
There was a problem hiding this comment.
Why do we need to make any changes to the prompt for self-checking mode for reasoning vs non-reasoning LLMs, now we're using Langchain's parser to split off reasoning tokens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack Info
This PR is part of a stack:
#1427 → #1431
Description
Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.