Skip to content

Update ego4robo doc#707

Open
shaosu-nvidia wants to merge 2 commits into
mainfrom
ssx/ego4robo_vdr_update
Open

Update ego4robo doc#707
shaosu-nvidia wants to merge 2 commits into
mainfrom
ssx/ego4robo_vdr_update

Conversation

@shaosu-nvidia

@shaosu-nvidia shaosu-nvidia commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Documentation
    • Expanded the hand reconstruction guide with clearer setup requirements, including system resources, Docker-related setup, Python tooling, and utility installation.
    • Added new reference images to help illustrate expected inputs and fitting results.
    • Clarified MANO file preparation steps and where to place required files.
    • Updated the video-capture reference link to point to the current camera plugin page.
    • Noted that reconstruction can now use both s3:// and swift:// URLs, with automatic download into the output folder.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f6890c98-015e-4407-b708-d5b56245bdfa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated the egocentric hand reconstruction reference documentation with new example images, an external OAK camera plugin link, expanded system requirements and setup instructions, revised MANO file preparation steps, and clarified that reconstruction inputs can be local paths or s3:// and swift:// URLs with automatic download to outputs/.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the documentation-only change and gives a concise summary of the PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssx/ego4robo_vdr_update

Comment @coderabbitai help to get the list of available commands.

@shaosu-nvidia

Copy link
Copy Markdown
Contributor Author

/preview-docs

@github-actions

Copy link
Copy Markdown
Contributor

✅ Preview deployed: https://NVIDIA.github.io/IsaacTeleop/preview/pr-707/

@shaosu-nvidia shaosu-nvidia changed the title Update ego4robo doc from VDR feedback Update ego4robo doc Jun 25, 2026
Also make small modification to the osmo readme
@shaosu-nvidia shaosu-nvidia force-pushed the ssx/ego4robo_vdr_update branch from 8271fba to d639b3f Compare June 25, 2026 21:43

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nv-jakob shouldn't this go into git lfs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one is 1.4MB and the other is 445KB, should be fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants