fix(web): unpin webpack now that 5.108.1 fixes the bundle corruption#712
Merged
Conversation
Reverts the pin added in #705. That pin forced webpack 5.105.4 because CI's fresh install resolved 5.108.0, which mis-emits re-export property chains and crashes React-Three-Fiber at Canvas init (runtime-only). webpack 5.108.1 has since shipped. Unpin so a fresh install floats to the latest 5.x to check whether the minification regression is fixed. Draft / do NOT merge as-is: IsaacTeleop CI does not build or load the web client on PRs, and the failure is runtime-only, so a green CI does not prove the bundle is good. Verify by clean-installing + building the client and loading it in a browser before relying on this. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Instead of floating, pin the known-bad 5.108.0 so the CI page build is deterministic. 5.108.0 mis-emits re-export property chains and crashes React-Three-Fiber at Canvas init. If the built page fails to load, the repro is confirmed; then test 5.108.1 to see if upstream fixed it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removes the webpack 5.105.4 pin added in #705. That pin worked around webpack 5.108.0, which mis-emitted re-export property chains and crashed React-Three-Fiber at Canvas init. Confirmed on this branch: 5.108.0 reproduced the crash, 5.108.1 builds and loads clean. Unpin so a fresh install floats to the fixed 5.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yanziz-nvidia
changed the title
jiwenc-nv
approved these changes
Jun 26, 2026
Contributor
|
Works for me (after blowing away build and node_modules/webpack, and running npm install) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
webpack: 5.105.4pin added in #705 (one line indeps/cloudxr/webxr_client/package.json), letting a fresh install float to the latest 5.x.Why
The pin worked around webpack 5.108.0, which mis-emitted re-export property chains (e.g.
s.A.C.E.S…) and crashed React-Three-Fiber at Canvas init — the client failed to load.Verified on this branch:
So the pin is no longer needed.
Note
Install is still floating (lockfile is gitignored, CI does a fresh install), so a future webpack minor could regress the same way. The durable fix is committing a lockfile +
npm ci— tracked separately.🤖 Generated with Claude Code
Summary by CodeRabbit