fix(e2e): add gateway connectivity retry before recovery approve

[hunglp6d]

Summary

✨ [AI-generated PR]

The issue-4462-gateway-pinned-approval-characterization-e2e nightly job fails intermittently because the gateway WebSocket is transiently unreachable after the legacy approve characterization step deliberately provokes a failure. The recovery openclaw devices approve fires immediately without waiting, hitting gateway connect failed.

This PR adds a short polling loop (5 attempts x 2 s) that waits for device_state_json to succeed before issuing the recovery approve, giving the gateway time to stabilise.

Root Cause

Between the June 12 and June 13 nightlies, commits b747bfa and 09a5c69 hardened the recovery proxy-env sourcing path. The legacy approve's failed WebSocket request leaves the gateway briefly unstable; the test's recovery approve fires instantly without any backoff. This is a test-side timing issue, not a product bug.

Changes

• test/e2e/test-issue-4462-scope-upgrade-approval.sh: Insert a gateway-readiness polling loop in legacy_gateway_pinned_approval_characterization() before the recovery approve_request call.

Nightly Run

• Failing run: https://github.com/NVIDIA/NemoClaw/actions/runs/27450816965
• Failing job: issue-4462-gateway-pinned-approval-characterization-e2e / run
• Error: FAIL: recovery after legacy characterization: openclaw devices approve failed... gateway connect failed: G
• Classification: infra_flake — transient gateway unreachability after deliberate failure

Test Plan

• Re-run issue-4462-gateway-pinned-approval-characterization-e2e E2E job with this fix
• Verify the retry loop logs gateway not yet reachable on transient failures
• Confirm the recovery approve succeeds after the retry

Signed-off-by: Hung Le hple@nvidia.com

Fixes #5377

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8ad876d5-50c3-4b17-ac9a-a968cc5679b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hunglp6d]

This is AI-generated PR.
Closed due to a fix was merge #5412