Skip to content

fix(e2e): add gateway connectivity retry before recovery approve #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hunglp6d wants to merge 1 commit into from
+17 −0
Closed

fix(e2e): add gateway connectivity retry before recovery approve #5375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/e2e/test-issue-4462-scope-upgrade-approval.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,23 @@ exit 0
if [ -n "$pending_after" ]; then
pass "legacy gateway-pinned approve leaves the CLI scope-upgrade request pending"
recovery_request_id="$pending_after"
# Wait for the gateway WebSocket to stabilise after the legacy approve
# failure — the failed request can leave the connection transiently
# unreachable, causing an immediate recovery approve to fail with
# "gateway connect failed".
local gw_ready=0
for _gw_attempt in 1 2 3 4 5; do
if device_state_json >/dev/null 2>&1; then
gw_ready=1
break
fi
info "gateway not yet reachable (attempt ${_gw_attempt}/5), waiting 2 s …"
sleep 2
done
if [ "$gw_ready" -eq 0 ]; then
fail "gateway did not become reachable within 10 s after legacy approve failure"
return 1
fi
approve_request "$recovery_request_id" "recovery after legacy characterization" 1 || return 1
pass "fixed devices approve path recovers the pending legacy request"
return 0
Expand Down
Loading