Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad MXFP8 scale inverses at the time of creation #1431

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

ksivaman
Copy link
Member

Description

Scaling factors need to be a multiple of 128 and 4 in the m, k directions respectively. This PR creates the correct sized scale inverses instead of padding them later.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my changes are stylistic.

Once we have this in, we can modify the MXFP8 tests to have the same tensor dims as FP8 (#1435). This will be useful for maintaining tight numerical tolerances and fixing some remaining test failures.

tests/pytorch/test_cuda_graphs.py Outdated Show resolved Hide resolved
transformer_engine/pytorch/csrc/common.h Outdated Show resolved Hide resolved
transformer_engine/pytorch/tensor/mxfp8_tensor.py Outdated Show resolved Hide resolved
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman ksivaman merged commit cffec60 into NVIDIA:release_v2.0 Jan 29, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants