Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Revert tensor dimensions in MXFP8 tests #1435

Open
wants to merge 2 commits into
base: release_v2.0
Choose a base branch
from

Conversation

timmoon10
Copy link
Collaborator

Description

We increased the tensor dimensions in some unit tests due to an MXFP8 requirement that tensor dims are multiples of 128, but this also increased numerical errors and caused test failures. #1431 relaxed that constraint to being a multiple of 32, so this PR reverts the unit test tensor dimensions back to their original values.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring
  • Testing

Changes

  • Revert tensor dimensions in MXFP8 tests

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Dims are multiples of 32 instead of 128.

Signed-off-by: Tim Moon <[email protected]>
@timmoon10 timmoon10 added bug Something isn't working testing Improvements to tests or testing infrastructure 2.0.0 labels Jan 29, 2025
@timmoon10 timmoon10 requested a review from ksivaman January 29, 2025 02:32
@timmoon10
Copy link
Collaborator Author

Pipeline 23264050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 bug Something isn't working testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant