Skip to content

chore(styles): remove invalid overflow-wrap visual quarantine - #222

Merged
coryrylan merged 1 commit into
mainfrom
upkeep/bug/remove-overflow-wrap-visual
Aug 15, 2026
Merged

chore(styles): remove invalid overflow-wrap visual quarantine#222
coryrylan merged 1 commit into
mainfrom
upkeep/bug/remove-overflow-wrap-visual

Conversation

@cursor

@cursor cursor Bot commented Aug 15, 2026

Copy link
Copy Markdown

Summary

Removes the quarantined visual test row should allow break words when wrapping long text using min-height and its baseline row-align-wrap-with-overflow-wrap.png.

This deletion was requested by the maintainer during the upkeep run that selected this stuck target.

Selected task

  • Task: bug
  • Target: projects/styles/src/layout.test.visual.ts:528
  • Rationale (selector): "quarantined skip test "row should allow break words when wrapping long text using min-height" describes behavior that should work but does not"

The agent originally stopped because un-skipping the test fails at ~3.6% under CI=true and the skill forbids updating visual baselines. The maintainer confirmed the test is no longer valid, so the correct fix is deletion rather than a baseline rewrite.

Before / after

  • Before: 1 quarantined visual (test.skip) + baseline PNG in projects/styles/.visual/
  • After: test and baseline removed; layout.test.visual.ts has 40 passing tests (was 41 with 1 skipped)

Verification

  • projects/styles: lint, test, test:lighthouse, test:visual (layout suite, CI=true) — pass
  • Root pnpm run ci — pass
  • test:types / test:axe / test:ssr — not present for styles

Notes

  • No public API changed
  • No production CSS or layout behavior changed
  • Left alone: all other layout/typography visual baselines and tests
Open in Web View Automation 

Deletes the skipped row overflow-wrap visual and its baseline. The
test is no longer valid per maintainer request.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@coryrylan coryrylan added the upkeep label Aug 15, 2026 — with Cursor
@coryrylan coryrylan added the upkeep label Aug 15, 2026 — with Cursor
@coryrylan
coryrylan marked this pull request as ready for review August 15, 2026 23:39
@coryrylan
coryrylan merged commit 8d03d28 into main Aug 15, 2026
15 checks passed
@coryrylan
coryrylan deleted the upkeep/bug/remove-overflow-wrap-visual branch August 15, 2026 23:39
@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.3.2 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.0.1 🎉

Changelog

@coryrylan

Copy link
Copy Markdown
Collaborator

🎉 This issue has been resolved in version 2.1.3 🎉

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants