Skip to content

chore(styles): remove invalid overflow-wrap visual quarantine #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryrylan merged 1 commit into from
Aug 15, 2026
Merged

chore(styles): remove invalid overflow-wrap visual quarantine #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions projects/styles/.visual/row-align-wrap-with-overflow-wrap.png
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions projects/styles/src/layout.test.visual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,20 +525,6 @@ describe('row visual', () => {
expect(report.maxDiffPercentage).toBeLessThan(1);
});

test.skip('row should allow break words when wrapping long text using min-height', async () => {
const report = await visualRunner.render(
'row-align-wrap-with-overflow-wrap',
/* html */ `
<section nve-layout="row align:wrap gap:lg" style="width: 150px;">
<!-- https://defensivecss.dev/tip/flexbox-min-content-size/ -->
<p style="margin: 0; overflow-wrap: break-word; min-width: 0;">•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎•︎</p>
</section>
`
);

expect(report.maxDiffPercentage).toBeLessThan(1);
});

test('rows with nested rows should match visual baseline', async () => {
const report = await visualRunner.render(
'rows-with-nested-rows',
Expand Down