Hot Fix: Backwards compatibility for results download spreadsheet#638
Merged
Conversation
REopt_API v3.12.0 using REopt.jl v0.51.0
v3.12.1 After Tax Savings and Results Table Spreadsheet Updates
Contributor
There was a problem hiding this comment.
Pull Request Overview
This hot fix improves backwards compatibility of the downloadable results spreadsheet by ensuring that None values are handled as zeros. The PR updates the safe_get function in custom_table_helpers.py, adjusts financial key references in custom_table_config.py, and revises Julia deployment configurations in the helm values file.
- Modified safe_get to ensure non-None return values.
- Replaced outputs.CHP with outputs.Financial keys in lambda expressions.
- Updated Julia replica count and added a rolling update strategy in the helm configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| reoptjl/custom_table_helpers.py | Enhanced safe_get function to return 0 instead of None. |
| reoptjl/custom_table_config.py | Updated standby cost key references to use outputs.Financial values. |
| .helm/values.production.yaml | Adjusted Julia replica count and added a deployment strategy. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the downloadable results spreadsheet to work with previous runs by avoiding errors when trying to do math with values of type None - handle None as zero/0:
safe_getfunction inreoptjl/custom_table_helpers.pyto ensure it returns a non-Nonevalue by falling back to0if both the key lookup and the default value areNone. This improves robustness when handling missing or null data.bau_valueandscenario_valuelambdas inreoptjl/custom_table_config.pyto useoutputs.Financial.year_one_chp_standby_cost_*instead ofoutputs.CHP.year_one_standby_cost_*for robustness becauseFinancialis always included andCHPis not.