Sampling regions characteristic#1418
Draft
afontani wants to merge 48 commits into
Draft
Conversation
12 tasks
The New Stratified Sampler supports the new sampling method under development in ResStock.
The `sampler.py` module was recently renamed to `run_sampler.py`. This commit updates the `resstock-sampler` script definition in `pyproject.toml` to correctly point to the `main` function within the new `run_sampler` module.
Replaces a hardcoded magic number and a repeated configuration lookup with a single `num_samples_per_segment` variable. This ensures the limit for rows per group consistently matches the configured or default value, improving clarity and maintainability.
8 tasks
| random.seed(42) | ||
|
|
||
|
|
||
| def test_get_samples() -> None: |
There was a problem hiding this comment.
Is this file actually being run on the ci? It looks like maybe not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add the sampling region characteristic ahead of the geographic resolution refactor.
CEC Climate zone is modified slightly: By assigning a climate zone to a census tract. Census tracts with multiple CEC climate zones are assigned to the climate zone with the largest number of units. This has little impact, there is some small changes to the distributions ~3% in some County and PUMAs in California.
Related Pull Requests
https://github.com/NREL/resstock-estimation/pull/463
Related Issues
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run