Address various bugs in physical trough model#1393
Merged
taylorbrown75 merged 18 commits intodevelopfrom May 8, 2026
Merged
Conversation
Remove duplicate min max velocity calculations.
There was a problem hiding this comment.
Pull request overview
This PR fixes several correctness issues in the physical trough model implementation across the TCS trough receiver and the SSC trough physical compute module, primarily around unit handling, messaging, and control-flow bugs.
Changes:
- Correct temperature and angle unit handling (avoid double °C→K conversion for HTF properties; compare solar azimuth in radians).
- Remove duplicate SSC variable table entries and fix an incorrect module name in an exception.
- Fix unintended switch fallthrough in
m_dot_runner()by adding missingbreakstatements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tcs/csp_solver_trough_collector_receiver.cpp | Fixes unit conversions for HTF property calls, corrects solar azimuth comparison units, and prevents switch fallthrough in runner mass flow logic. |
| ssc/cmod_trough_physical.cpp | Removes duplicate var table entries and corrects the module label used in an exec_error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25564131132Coverage decreased (-0.007%) to 56.275%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions941 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Addresses the following bugs in the physical trough model
Corresponding branches and PRs:
wex, lk, SAM: develop
Unit Test Impact:
SSC unit tests pass. Expect changes to SAM regression tests.
Checklist