Skip to content

Address various bugs in physical trough model #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorbrown75 merged 18 commits into from
May 8, 2026
Merged

Address various bugs in physical trough model #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
14ff33a
Add solar position/IAM table option to trough.
taylorbrown75 Apr 6, 2026
46a42b4
Rename optical table input.
taylorbrown75 Apr 6, 2026
73c3218
Add optical table option to trough for each collector.
taylorbrown75 Apr 29, 2026
7fcbb61
Add optical table support to trough IPH
taylorbrown75 Apr 29, 2026
b843fa9
Merge branch 'develop' into trough_optical_table
taylorbrown75 Apr 29, 2026
03ff325
Fix test bug.
taylorbrown75 Apr 30, 2026
41f7b68
Address copilot review comments.
taylorbrown75 Apr 30, 2026
5497fce
Fix end gain unit bug.
taylorbrown75 Apr 30, 2026
074f3e0
Remove duplicate T_startup and T_shutdown.
taylorbrown75 Apr 30, 2026
f172fde
Fix error mislabel.
taylorbrown75 Apr 30, 2026
9e65203
Fix design solar mult unit issue.
taylorbrown75 Apr 30, 2026
b7435bc
Add missing breaks to m_dot_runner calculation.
taylorbrown75 Apr 30, 2026
d010756
Fix min field flow velocity calculation.
taylorbrown75 Apr 30, 2026
7bbd20a
Merge branch 'develop' into trough_bugs
taylorbrown75 May 1, 2026
73dac77
Update trough tests relevant to bug fixes.
taylorbrown75 May 5, 2026
00bc3cb
Merge branch 'develop' into trough_optical_table
taylorbrown75 May 5, 2026
70e4b26
Merge branch 'trough_optical_table' into trough_bugs
taylorbrown75 May 7, 2026
69b27cb
Merge branch 'develop' into trough_bugs
taylorbrown75 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions ssc/cmod_trough_physical.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ static var_info _cm_vtab_trough_physical[] = {
{ SSC_INPUT, SSC_NUMBER, "Row_Distance", "Spacing between rows (centerline to centerline)", "m", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "T_loop_in_des", "Design loop inlet temperature", "C", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "T_loop_out", "Target loop outlet temperature", "C", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "T_startup", "Required temperature of the system before the power block can be switched on", "C", "", "solar_field", "?", "", "" },
{ SSC_INPUT, SSC_NUMBER, "T_shutdown", "Temperature when solar field begins recirculating", "C", "", "solar_field", "?", "", "" },

{ SSC_INPUT, SSC_NUMBER, "use_abs_or_rel_mdot_limit", "Use mass flow abs (0) or relative (1) limits", "", "", "solar_field", "?=0", "", "" },
{ SSC_INPUT, SSC_NUMBER, "m_dot_htfmin", "Minimum loop HTF flow rate", "kg/s", "", "solar_field", "use_abs_or_rel_mdot_limit=0", "", "" },
Expand Down Expand Up @@ -130,6 +128,11 @@ static var_info _cm_vtab_trough_physical[] = {
{ SSC_INPUT, SSC_ARRAY, "L_aperture", "Length of a single mirror/HCE unit", "m", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "ColperSCA", "Number of individual collector sections in an SCA ", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "Distance_SCA", "Piping distance between SCA's in the field", "m", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "opt_model", "Optical model (1=Solar position ; 2=Collector incidence table ; 3=IAM matrix)", "", "", "solar_field", "?=[3,3,3,3]", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_1", "Values of the optical efficiency table for collector type 1", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_2", "Values of the optical efficiency table for collector type 2", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_3", "Values of the optical efficiency table for collector type 3", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_4", "Values of the optical efficiency table for collector type 4", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "IAM_matrix", "IAM coefficients, matrix for 4 collectors", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_MATRIX, "HCE_FieldFrac", "Fraction of the field occupied by this HCE type ", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_MATRIX, "D_2", "Inner absorber tube diameter", "m", "", "solar_field", "*", "", "" },
Expand Down Expand Up @@ -593,7 +596,7 @@ static var_info _cm_vtab_trough_physical[] = {
// Solar Field
{ SSC_OUTPUT, SSC_ARRAY, "Theta_ave", "Field collector solar incidence angle", "deg", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "CosTh_ave", "Field collector cosine efficiency", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "IAM_ave", "Field collector incidence angle modifier", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "opt_derate_ave", "Field collector optical derate modifier", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "RowShadow_ave", "Field collector row shadowing loss", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "EndLoss_ave", "Field collector optical end loss", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "dni_costh", "Field collector DNI-cosine product", "W/m2", "", "solar_field", "sim_type=1", "", "" },
Expand Down Expand Up @@ -1149,8 +1152,23 @@ class cm_trough_physical : public compute_module
for (size_t i = 0; i < nval_Distance_SCA; i++)
c_trough.m_Distance_SCA[i] = (double)Distance_SCA[i];

c_trough.m_opt_model = as_vector_integer("opt_model"); // Optical model 1=Solar position ; 2=Collector incidence table ; 3 = IAM matrix)
c_trough.m_IAM_matrix = as_matrix("IAM_matrix"); //[-] IAM coefficients, matrix for 4 collectors

for (int i = 0; i < c_trough.m_opt_model.size(); i++)
{
int opt_model = c_trough.m_opt_model[i];
c_trough.m_OpticalTables_in.push_back(util::matrix_t<double>());
if (opt_model != 3)
{
std::string OpticalTable_varname = "OpticalTable_" + std::to_string(i + 1);
if (!is_assigned(OpticalTable_varname))
throw exec_error("trough_physical", "opt_model 1 and 2 must have OpticalTable assigned.");
else
c_trough.m_OpticalTables_in[i] = as_matrix(OpticalTable_varname);
}
}

// Why are these matrices - can't they be arrays?
c_trough.m_HCE_FieldFrac = as_matrix("HCE_FieldFrac"); //[-] Fraction of the field occupied by this HCE type
c_trough.m_D_2 = as_matrix("D_2"); //[m] Inner absorber tube diameter
Expand Down Expand Up @@ -1238,7 +1256,7 @@ class cm_trough_physical : public compute_module
{
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_THETA_AVE, allocate("Theta_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_COSTH_AVE, allocate("CosTh_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_IAM_AVE, allocate("IAM_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_OPT_DERATE_AVE, allocate("opt_derate_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_ROWSHADOW_AVE, allocate("RowShadow_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_ENDLOSS_AVE, allocate("EndLoss_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_DNI_COSTH, allocate("dni_costh", n_steps_fixed), n_steps_fixed);
Expand Down Expand Up @@ -1785,7 +1803,7 @@ class cm_trough_physical : public compute_module
else if (csp_financial_model == 7 || csp_financial_model == 8) { // LCOE (7) and None (8)

if (is_dispatch) {
throw exec_error("fresnel_physical", "Can't select dispatch optimization if No Financial model");
throw exec_error("trough_physical", "Can't select dispatch optimization if No Financial model");
}
else { // if no dispatch optimization, don't need an input pricing schedule
// If electricity pricing data is not available, then dispatch to a uniform schedule
Expand Down
24 changes: 22 additions & 2 deletions ssc/cmod_trough_physical_iph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ static var_info _cm_vtab_trough_physical_iph[] = {
{ SSC_INPUT, SSC_ARRAY, "L_aperture", "Length of a single mirror/HCE unit", "m", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "ColperSCA", "Number of individual collector sections in an SCA ", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "Distance_SCA", "Piping distance between SCA's in the field", "m", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "opt_model", "Optical model (1=Solar position ; 2=Collector incidence table ; 3=IAM matrix)", "", "", "solar_field", "?=[3,3,3,3]", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_1", "Values of the optical efficiency table for collector type 1", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_2", "Values of the optical efficiency table for collector type 2", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_3", "Values of the optical efficiency table for collector type 3", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "OpticalTable_4", "Values of the optical efficiency table for collector type 4", "", "", "solar_field", "", "", "" },
{ SSC_INPUT, SSC_MATRIX, "IAM_matrix", "IAM coefficients, matrix for 4 collectors", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_MATRIX, "HCE_FieldFrac", "Fraction of the field occupied by this HCE type ", "none", "", "solar_field", "*", "", "" },
{ SSC_INPUT, SSC_MATRIX, "D_2", "Inner absorber tube diameter", "m", "", "solar_field", "*", "", "" },
Expand Down Expand Up @@ -552,7 +557,7 @@ static var_info _cm_vtab_trough_physical_iph[] = {
// Solar Field
{ SSC_OUTPUT, SSC_ARRAY, "Theta_ave", "Field collector solar incidence angle", "deg", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "CosTh_ave", "Field collector cosine efficiency", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "IAM_ave", "Field collector incidence angle modifier", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "opt_derate_ave", "Field collector optical derate modifier", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "RowShadow_ave", "Field collector row shadowing loss", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "EndLoss_ave", "Field collector optical end loss", "", "", "solar_field", "sim_type=1", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "dni_costh", "Field collector DNI-cosine product", "W/m2", "", "solar_field", "sim_type=1", "", "" },
Expand Down Expand Up @@ -1051,8 +1056,23 @@ class cm_trough_physical_iph : public compute_module
for (size_t i = 0; i < nval_Distance_SCA; i++)
c_trough.m_Distance_SCA[i] = (double)Distance_SCA[i];

c_trough.m_opt_model = as_vector_integer("opt_model"); // Optical model 1=Solar position ; 2=Collector incidence table ; 3 = IAM matrix)
c_trough.m_IAM_matrix = as_matrix("IAM_matrix"); //[-] IAM coefficients, matrix for 4 collectors

for (int i = 0; i < c_trough.m_opt_model.size(); i++)
{
int opt_model = c_trough.m_opt_model[i];
c_trough.m_OpticalTables_in.push_back(util::matrix_t<double>());
if (opt_model != 3)
{
std::string OpticalTable_varname = "OpticalTable_" + std::to_string(i + 1);
if (!is_assigned(OpticalTable_varname))
throw exec_error("trough_physical_iph", "opt_model 1 and 2 must have OpticalTable assigned.");
else
c_trough.m_OpticalTables_in[i] = as_matrix(OpticalTable_varname);
}
}

// Why are these matrices - can't they be arrays?
c_trough.m_HCE_FieldFrac = as_matrix("HCE_FieldFrac"); //[-] Fraction of the field occupied by this HCE type
c_trough.m_D_2 = as_matrix("D_2"); //[m] Inner absorber tube diameter
Expand Down Expand Up @@ -1146,7 +1166,7 @@ class cm_trough_physical_iph : public compute_module
{
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_THETA_AVE, allocate("Theta_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_COSTH_AVE, allocate("CosTh_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_IAM_AVE, allocate("IAM_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_OPT_DERATE_AVE, allocate("opt_derate_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_ROWSHADOW_AVE, allocate("RowShadow_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_ENDLOSS_AVE, allocate("EndLoss_ave", n_steps_fixed), n_steps_fixed);
c_trough.mc_reported_outputs.assign(C_csp_trough_collector_receiver::E_DNI_COSTH, allocate("dni_costh", n_steps_fixed), n_steps_fixed);
Expand Down
Loading
Loading