LocalStore::addTempRoot(): Handle ENOENT #8544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Ericson2314
reviewed
Jun 19, 2023
Ericson2314
reviewed
Jun 19, 2023
If the garbage collector has acquired the global GC lock, but hasn't created the GC socket yet, then a client attempting to connect would get ENOENT. Note that this only happens when the GC runs for the first time on a machine. Subsequently clients will get ECONNREFUSED which was already handled. Fixes NixOS#7370.
edolstra
force-pushed
the
handle-missing-gc-socket
branch
from
3823f7a to
c5fdbda
Compare
Co-authored-by: John Ericson <[email protected]>
Also name the _NIX_TEST_GC_SYNC environment variables logically.
This is necessary on macOS since addTempRoot() relies on errno.
edolstra
force-pushed
the
handle-missing-gc-socket
branch
from
5cabab5 to
d005bad
Compare
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
|
@edolstra should we do |
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 16, 2024
It is good to propogate the underlying error so whether or not we use a proccess to deal with path length issues is not observable. Also, as these helper functions got more and more complex, the code duplication got worse and worse. Deduplicate.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 16, 2024
It is good to propagate the underlying error so whether or not we use a process to deal with path length issues is not observable. Also, as these wrapper functions got more and more complex, the code duplication got worse and worse. The new `bindConnectProcHelper` function deduplicates them.
|
Did |
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
1 similar comment
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 17, 2024
It is good to propagate the underlying error so whether or not we use a process to deal with path length issues is not observable. Also, as these wrapper functions got more and more complex, the code duplication got worse and worse. The new `bindConnectProcHelper` function deduplicates them.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 18, 2024
It is good to propagate the underlying error so whether or not we use a process to deal with path length issues is not observable. Also, as these wrapper functions got more and more complex, the code duplication got worse and worse. The new `bindConnectProcHelper` function deduplicates them.
thufschmitt
added a commit
that referenced
this pull request
Jan 18, 2024
`bind`: give same treatment as `connect` in #8544, dedup
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
LocalStore: :addTempRoot(): Handle ENOENT (cherry picked from commit 7115edc) Change-Id: Ie6b1596049c3fde09b98f2f0727899f98e48e6b1
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
`bind`: give same treatment as `connect` in NixOS#8544, dedup (cherry picked from commit 2867424) Change-Id: I1ac5fc43fa10ec5f37a226730c3d84033fdbfd52
|
Backport to Nix-2.18 here: #13896. There was an attempt by @roberth to backport this to 2.18 and 2.15 above (#8544 (comment)) but that failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the garbage collector has acquired the global GC lock, but hasn't created the GC socket yet, then a client attempting to connect would get ENOENT. Note that this only happens when the GC runs for the first time on a machine. Subsequently clients will get ECONNREFUSED which was already handled.
Fixes #7370.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.