bind: give same treatment as connect in #8544, dedup
#9787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Ericson2314
force-pushed
the
bind-proc-syserror
branch
from
4823734 to
0ebeb07
Compare
It is good to propagate the underlying error so whether or not we use a process to deal with path length issues is not observable. Also, as these wrapper functions got more and more complex, the code duplication got worse and worse. The new `bindConnectProcHelper` function deduplicates them.
Ericson2314
force-pushed
the
bind-proc-syserror
branch
from
0ebeb07 to
3016e67
Compare
|
Very elegant! |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
`bind`: give same treatment as `connect` in NixOS#8544, dedup (cherry picked from commit 2867424) Change-Id: I1ac5fc43fa10ec5f37a226730c3d84033fdbfd52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is good to propagate the underlying error so whether or not we use a process to deal with path length issues is not observable.
Also, as these wrapper functions got more and more complex, the code duplication got worse and worse. The new
bindConnectProcHelperfunction deduplicates them.Context
#8544
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.