Open
Conversation
|
8cfd5a0 to
6917bfd
Compare
2 tasks
6917bfd to
049758d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
irmodule into a separate crateslang_solidity_v2_irin line with the separation between thecstandparsercrates.CompilationUnitinto a parentmaincrate which should serve as the user-facing crate to access the parser and the semantic analysis.BinderandTypeRegistryinto aSemanticContextwhich can be constructed in thesemanticcrate to keep the passes private.Fileimplementation is moved to the newmaincrate, but it implements anInputFiletrait for thesemanticcrate needs.CompilationUnit#1577.resolve_identifier_pathused in both p2 and p3, addressing this thread from [v2] Migrate semantic passes and portCompilationUnit#1577.CompilationUnit#1577.