-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from OSGeo Weblate #4063
Conversation
Can I try to use "rebase" on the GitHub PR to update the branch, and see if it makes something different than the 4+ other tries that never fixed the problem (fixes until another PR is merged and Weblate isn't up to date with main)? Considering that weblate locked up again a couple hours after it was unlocked this morning |
I just tried "Update with rebase" and got this error:
and the problem is I cannot run those suggested commands manually on Weblate :-(. Maybe, we should try options in the "Danger zone". |
I can't help you with anything on the management side of weblate, as I never saw them, nor do I have or ever had a staging setup to learn about it |
@HuidaeCho take a look at these docs from another project using Weblate. It's one of the first that I find different info and procedures yet. And they use squash merges. https://forgejo.org/docs/next/developer/localization-admin/ |
Does @robe2 have an idea here? |
Nice meeting you @HuidaeCho at FOSS4GNA. @neteler @HuidaeCho I'm not sure what I did to fix last time. Right now, for the Weblate translations, to unlock, the only option that worked is below which I ddi So now weblate shows 0 commits missing, but it is showing 10 outgoing commits. Pushing doesn't seem to do anything perhaps because this pull request hasn't been merged yet. So I would try merging this and see if the weblate now shows right. For messy divergencies, you can add weblate repo as a remote, do any local rebasing, fixing Something like
Once you are sure you have captured all weblate changes you need, it's safe to go back to weblate grass admin panel and run this. One case where I had to resort to this is when I did a force push into the postgis repository. Weblate does not like force pushes (and I admit now, that was a lousy thing to do just to destroy junk history), but I knew all changes were already captured in PostGIS, so it was safe for me to force weblate to match the postgis upstream repo. |
The thing is, the commits from this PR were already merged in other weblate PRs. But since we use squash-merge, weblate doesn't update itself. And each time weblate gets manually unlocked like what happened a couple hours ago, gets locked back up when we merge a new PR, like what just happened. |
Yes, it's documented in their docs that they have a hard time with it. |
There is a weblate add-on that does squashing. What if you just install that on your weblate project so that weblate does the squashing for at least it's own pull requests? Not sure if that would help with the non-weblate pull requests. It also looks like you have no add-ons installed in weblate GRASS project. Might want to check them out to see which ones might be valuable for GRASS. https://weblate.osgeo.org/addons/grass-gis/grasslibs/ FWIW the ones we have enabled for postgis-workshop are:
For PostGIS we have these ones.
We rarely do squashes in either project so might be why we don't run into this issue |
@robe2 I have a question, how do you keep your strings to translate to be kept updated with the code as commits are made? Do you do it on the weblate side, or have CI for that? |
We do build of the .pot file on our commits and let weblate create and update the POS as needed. The weblate add-on that does that is the one called Update PO files to match POT (msgmerge) I don't think there is a way for weblate to create the POTs as well, but I could be mistaken. Probably better to have your CI do that or do it manually every so often like we do. So here is an example: I updated the POT file in this - https://git.osgeo.org/gitea/postgis/postgis/commit/f83f784268aac67e92fdbf0d55a007161d94ac34 and weblate did a commit after updating all our POs. https://git.osgeo.org/gitea/postgis/postgis/commit/39f89ae61840b7587bb19cf0ae83f0870d2e89cd |
Since all these files have been written to the repo already, how about we:
|
Please do, we are stuck with the same changes in a PR loop since June 2, #3741, and can't really have new contributions since then. I have no access to see any settings, so I rely on the two or three people that do |
Does any newer release of Weblate since the 5.4.3 that we have has related improvements that would be helpful? There seems to be a bug fix for the installation of the squash git commits plugin in 5.5.1: https://docs.weblate.org/en/latest/changes.html#weblate-5-5-1 |
The translations got unlocked today, but locked back exactly 15 minutes later when a new PR was merged. |
Ok, it seems that weblate rebased automatically 11 times, since @HuidaeCho unlocked it, each time the repo changed. That's a good sign. Do we try merging this PR in and see what happens? |
670a594
to
9a8d6ec
Compare
@neteler should this be merged before or after 8.4.1, as we pretty much ignored it since the 8.4.0 release as it was locked |
ae103e5
to
7a5bb9a
Compare
Currently translated at 93.1% (1688 of 1812 strings) Translation: GRASS GIS/grasslibs Translate-URL: https://weblate.osgeo.org/projects/grass-gis/grasslibs/fr/
Currently translated at 89.6% (3831 of 4272 strings) Translation: GRASS GIS/grasswxpy Translate-URL: https://weblate.osgeo.org/projects/grass-gis/grasswxpy/fr/
Currently translated at 21.0% (2862 of 13590 strings) Translation: GRASS GIS/grassmods Translate-URL: https://weblate.osgeo.org/projects/grass-gis/grassmods/fr/
7a5bb9a
to
97caca2
Compare
@neteler or others, we need to decide what to do here, as it gets rebased for each PR merged, and runs a new set of CI for every commit on main (slowing every project on the OSGeo github org), until we decide to merge now or not |
Hi @echoix, I think we should merge it and see. |
Let's go! |
Can someone force merge to skip the queue, as we are actively merging to main, and the last runs were all fine |
Just installed the Squash addon on Weblate. Hope that helps. |
Translations update from OSGeo Weblate for GRASS GIS/grasslibs.
It also includes following components:
GRASS GIS/grasswxpy
GRASS GIS/grassmods
Current translation status: