Add a type for modeling multiple-dimensional gas #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the package multigas that contains the code related to multi-dimensional gas. It adds the ResourceKind enum that represents a gas resource, and the ResourceConstraints struct that represents a set of constraints. Close NIT-3487
There was a problem hiding this comment.
Pull Request Overview
This PR defines a new multigas package to model per-resource gas constraints for the EVM.
- Introduces
ResourceKindenum andMultiGasarray type - Implements
ResourceConstraintsmap withSetConstraintandClearConstraintmethods - Adds unit tests covering basic constraint operations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| arbitrum/multigas/resources.go | Defines ResourceKind enum and MultiGas type |
| arbitrum/multigas/doc.go | Adds package-level documentation |
| arbitrum/multigas/constraint.go | Implements ResourceConstraints type and its methods |
| arbitrum/multigas/constraint_test.go | Tests for adding, updating, and clearing resource constraints |
Comments suppressed due to low confidence (3)
arbitrum/multigas/constraint.go:6
- The identifier 'constraint' collides with Go's generic 'constraint' keyword and is ambiguous. Consider renaming it to something more specific, e.g. 'resourceConstraint'.
type constraint struct {
arbitrum/multigas/constraint.go:23
- Exported constructor is missing a doc comment. Please add a comment describing what NewResourceConstraints returns and any initialization details.
func NewResourceConstraints() ResourceConstraints {
arbitrum/multigas/constraint_test.go:8
- The test currently covers only Computation and HistoryGrowth. Consider adding cases for StorageAccess and StorageGrowth to ensure all resource kinds are initialized and handled correctly.
func TestResourceConstraints(t *testing.T) {
eljobe
requested changes
Jul 2, 2025
Helps avoiding bugs when the kind is left uninitialized.
eljobe
requested changes
Jul 2, 2025
The resource constraint struct won't be used directly in go-ethereum, so we decided to move it to the nitro repository.
eljobe
approved these changes
Jul 3, 2025
gligneul
changed the title
gligneul
added a commit
to OffchainLabs/nitro
that referenced
this pull request
Jul 3, 2025
The ResourceConstraints struct tracks the constraints used in constraint-based pricing. Depends on OffchainLabs/go-ethereum#482 Close NIT-3487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the package multigas that contains the code related to multi-dimensional gas. It adds the ResourceKind enum that represents a gas resource.