-
Notifications
You must be signed in to change notification settings - Fork 134
Add a type for modeling multiple-dimensional gas #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7440768
Add a type for modeling a Resource Constraint
gligneul 61c1413
Fix typo
gligneul 28b015a
Rename constraint struct to resourceConstraint
gligneul 3d66c6b
Add documentation for NewResourceConstraints
gligneul 78af5bf
Check the length of all resources in test
gligneul 7380b46
Replace uint32 with PeriodSecs type
gligneul df5fb1d
Improve error messages of unit tests
gligneul 32d2183
Add resource kind unknown
gligneul 721d353
Move resource constraint to nitro repo
gligneul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// Package multigas defines multi-dimensional gas for the EVM. | ||
eljobe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// | ||
// This package introduces mechanisms to track each resource used by the EVM separately. The | ||
// possible resources are computation, history growth, storage access, and storage growth. By | ||
// tracking each one individually and setting specific constraints, we can increase the overall gas | ||
// target for the chain. | ||
package multigas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package multigas | ||
|
||
// ResourceKind represents a dimension for the multi-dimensional gas. | ||
type ResourceKind uint8 | ||
|
||
const ( | ||
ResourceKindUnknown ResourceKind = iota | ||
ResourceKindComputation | ||
ResourceKindHistoryGrowth | ||
ResourceKindStorageAccess | ||
ResourceKindStorageGrowth | ||
NumResourceKind | ||
) | ||
|
||
// MultiGas tracks gas for each resource separately. | ||
type MultiGas [NumResourceKind]uint64 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.