[MEL] - Use geth's FilterLogs function #3224
Merged
+46
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshvanahalli
changed the title
ganeshvanahalli
changed the title
rauljordan
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
filterLogsimpl indelayed_message_lookup.gofile, instead we use the exportedFilterLogsfunction from geth'sfilterspackage.Testing
We already have
TestMessageExtractionLayer_DelayedMessageEquivalence_Simplethat indirectly tests that the exported function works as intended, but we add an additional comparison check with ethclient'sFilterLogsmethod and verify they both return the same logs as a result insideTestBloomsystem_test.Pulls Geth PR- OffchainLabs/go-ethereum#453
Resolves NIT-3351