[typescript-fetch] Fix infinite recursion with self-referencing discriminator mappings #21956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sermler
changed the title
macjohnny
approved these changes
Oct 14, 2025
|
thanks for your contribution |
|
This PR has introduced no fixture changes. Can we check in a file that would have failed prior to the changes in this PR? Like the example from #21955 ? |
wing328
reviewed
Oct 15, 2025
| this.setComposedSchemas(cm.getComposedSchemas()); | ||
| if (this.discriminator != null) { | ||
| Set<CodegenDiscriminator.MappedModel> mappedModels = this.discriminator.getMappedModels(); | ||
| for(CodegenDiscriminator.MappedModel mappedModel : mappedModels) { |
There was a problem hiding this comment.
@sermler latest CI shows the following errors:
[pool-1-thread-5] Generation failed for typescript-fetch: (RuntimeException) Could not process model 'InternalAuthenticatedUserDto'.Please make sure that your schema is correct!
java.lang.RuntimeException: Could not process model 'InternalAuthenticatedUserDto'.Please make sure that your schema is correct!
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:519)
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:444)
at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:1292)
at org.openapitools.codegen.cmd.GenerateBatch$GenerationRunner.run(GenerateBatch.java:226)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1208)
at java.base/java.util.TreeMap$KeyIterator.next(TreeMap.java:1262)
at org.openapitools.codegen.languages.TypeScriptFetchClientCodegen$ExtendedCodegenModel.<init>(TypeScriptFetchClientCodegen.java:1607)
at org.openapitools.codegen.languages.TypeScriptFetchClientCodegen.fromModel(TypeScriptFetchClientCodegen.java:564)
at org.openapitools.codegen.languages.TypeScriptFetchClientCodegen.fromModel(TypeScriptFetchClientCodegen.java:48)
at org.openapitools.codegen.DefaultGenerator.processModels(DefaultGenerator.java:1754)
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:514)
... 6 more
can you please review and ideally come up with a fix?
thanks again for the contribution.
There was a problem hiding this comment.
Can you provide a link to the CI-Job so i can see how to reproduce this?
There was a problem hiding this comment.
There was a problem hiding this comment.
right.
or you can run ./bin/generate-samples.sh ./bin/configs/typescript-fetch-* locally (assuming you're using mac/linux or wsl under windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21955
Besides the infinite recursion this PR fixes the self import of the file.
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having
"fixes #123"present in the PR description)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)