Skip to content

Conversation

@sermler
Copy link
Contributor

@sermler sermler commented Oct 15, 2025

Reworks of #21956
Fixes #21956 (comment)
Adds fixture sample requested in #21956 (comment)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 15, 2025

please merge the latest master to your branch 🙏

@joscha
Copy link
Contributor

joscha commented Oct 15, 2025

Adds fixture sample requested in #21956 (comment)

thank you!

@sermler sermler force-pushed the bugfix/rework-self-referencing-discriminator branch from 29d036d to 55955a4 Compare October 15, 2025 11:06
@sermler
Copy link
Contributor Author

sermler commented Oct 15, 2025

done

@wing328
Copy link
Member

wing328 commented Oct 15, 2025

thanks for the quick fix.

let's give it a try

@wing328 wing328 merged commit a4a24a8 into OpenAPITools:master Oct 15, 2025
70 checks passed
@wing328 wing328 added this to the 7.17.0 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants