asynchronous/embassy: Introduce separate interrupt receiver struct#100
Open
RobertZ2011 wants to merge 2 commits intoOpenDevicePartnership:v0.2.0from
Open
asynchronous/embassy: Introduce separate interrupt receiver struct#100RobertZ2011 wants to merge 2 commits intoOpenDevicePartnership:v0.2.0from
RobertZ2011 wants to merge 2 commits intoOpenDevicePartnership:v0.2.0from
Conversation
RobertZ2011
force-pushed
the
interrupt-receiver
branch
2 times, most recently
from
6b4878d to
6957b14
Compare
Cargo Vet Audit Passed
|
RobertZ2011
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Embassy async interrupt handling by splitting interrupt processing and interrupt waiting into dedicated types, and updates examples/MSRV accordingly.
Changes:
- Extracted interrupt logic into a new
src/asynchronous/embassy/interrupt.rsmodule withInterruptProcessorandInterruptReceiver. - Updated Embassy controller/task APIs and examples to use
InterruptProcessor, and introducedcreate_interrupt_receiver()for waiting on interrupts. - Bumped MSRV to Rust 1.90, updated CI MSRV check, and added
embassy-futuresfor yielding support.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/asynchronous/embassy/task.rs | Updates interrupt task to operate on InterruptProcessor instances. |
| src/asynchronous/embassy/mod.rs | Replaces old Interrupt type with InterruptProcessor, adds create_interrupt_receiver(), and adjusts command waiting. |
| src/asynchronous/embassy/interrupt.rs | New module containing interrupt processing, guarded interrupt enable, and interrupt receiving/waiting logic + tests. |
| examples/rt685s-evk/src/bin/plug_status.rs | Uses InterruptProcessor for the IRQ task and InterruptReceiver for waiting on plug events. |
| examples/rt685s-evk/src/bin/fw_update.rs | Updates IRQ task to accept InterruptProcessor. |
| examples/rt685s-evk/Cargo.lock | Dependency lock updates (Embassy ecosystem + related crates). |
| examples/rt685s-evk/.cargo/config.toml | Changes default DEFMT_LOG level to trace. |
| Cargo.toml | Bumps rust-version to 1.90 and adds optional embassy-futures under the embassy feature. |
| Cargo.lock | Adds embassy-futures to the lockfile. |
| .github/workflows/check.yml | Updates the MSRV matrix to 1.90. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
6957b14 to
d0fbd17
Compare
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
d0fbd17 to
16ed82c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
16ed82c to
4f79808
Compare
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
4f79808 to
d14af70
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
d14af70 to
2922d62
Compare
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
2922d62 to
f0bbe0b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Create a struct to allow waiting for interrupts without needing to block the core controller object. Move interrupt related code into its own module.
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
f0bbe0b to
8c69db3
Compare
jerrysxie
previously approved these changes
Apr 16, 2026
RobertZ2011
force-pushed
the
interrupt-receiver
branch
from
89bd606 to
70947c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a struct to allow waiting for interrupts without needing to block the core controller object. Move interrupt related code into its own module.