Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhis2: Remove discover and switch to async/await #1077

Merged
merged 9 commits into from
Mar 20, 2025
Merged

dhis2: Remove discover and switch to async/await #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2bc74ba
fix: switch to `async/await`
hunterachieng Mar 19, 2025
16c2a00
feat:add state in docs
hunterachieng Mar 19, 2025
76834dd
fix: upsert duplicate error
hunterachieng Mar 19, 2025
8fdff12
fix:bumb axios version
hunterachieng Mar 19, 2025
f22ec96
fix: remove asBase64 and use parseAs:base64
hunterachieng Mar 19, 2025
61c566a
fix: add changeset
hunterachieng Mar 20, 2025
bf962df
fix: test `create`
hunterachieng Mar 20, 2025
ec02c1c
simplify code
josephjclark Mar 20, 2025
7c91619
lint
josephjclark Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/warm-pots-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'@openfn/language-dhis2': major
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunterachieng not all of these changes are major

It's ok to create multiple changeset files. You can have a 100 changes, created indivdually, no problem at all.

I'll fix this in the final changelog for the adaptor so no action needed now. But in future, good practice is to create a changeset every time you finish a feature that will affect users.

---

- Remove `discover()` function
- Switch to `async/await`
- Bump `axios` version to `1.8.2`
- Implement better `upsert()` multiple entinties error
- Fixed `get` with `parseAs:base64`
- Update state docs in jsDoc

32 changes: 30 additions & 2 deletions packages/dhis2/ast.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": null,
Expand Down Expand Up @@ -212,6 +216,10 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": null,
Expand Down Expand Up @@ -332,9 +340,13 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": "state",
"description": null,
"type": {
"type": "NameExpression",
"name": "Operation"
Expand Down Expand Up @@ -446,9 +458,13 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": "state",
"description": null,
"type": {
"type": "NameExpression",
"name": "Operation"
Expand Down Expand Up @@ -544,6 +560,10 @@
"name": "RangeError"
}
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": null,
Expand Down Expand Up @@ -639,6 +659,10 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": null,
Expand Down Expand Up @@ -732,6 +756,10 @@
},
"name": "callback"
},
{
"title": "state",
"description": "{Dhis2State}"
},
{
"title": "returns",
"description": null,
Expand Down
2 changes: 1 addition & 1 deletion packages/dhis2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
],
"dependencies": {
"@openfn/language-common": "workspace:*",
"axios": "^1.7.7",
"axios": "^1.8.2",
"lodash": "^4.17.21",
"qs": "^6.11.0"
},
Expand Down
Loading