fix(redis): quote key names in DEL/RENAME, apply grid edits atomically, iterate full SCAN cursor - #2308
Merged
Conversation
openai0229
force-pushed
the
fix/review-redis
branch
from
July 30, 2026 00:04
1e0bfa5 to
0a1dade
Compare
…elete emptied keys, loop+dedupe SCAN paths (code review follow-up)
…delete for duplicate values (codex review)
openai0229
force-pushed
the
fix/review-redis
branch
from
July 30, 2026 00:11
0a1dade to
60a723b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verified review findings tracked in #2281: (1) dropTable built DEL with a raw unquoted key name (wrong-key deletion on names with spaces); (2) buildByQueryResult iterated edits in an empty loop, silently dropping all grid edits — now emits per-type mutation commands inside MULTI/EXEC; list deletes are positional (tombstone LSET+LREM) so duplicate values cannot remove the wrong occurrence; (3) RENAME/EXPIRE built with raw names and EXPIRE emitted for sentinel TTLs; (4) deleting every field/member left an empty key instead of DEL; (5) SCAN listing truncated after the first batch — now loops the cursor with dedupe; (6) list rewrite (DEL+RPUSH) wrapped in MULTI/EXEC for atomicity. Regression tests added. Verified on fork HandSonic#8 (CI green).