Skip to content

v2: Remove parameter scale #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

v2: Remove parameter scale #408

merged 1 commit into from
Jul 22, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 21, 2025

parameterScale no longer exists in PEtab v2.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (bf4055c) to head (31c8bfc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   73.74%   73.86%   +0.12%     
==========================================
  Files          62       62              
  Lines        6794     6764      -30     
  Branches     1198     1194       -4     
==========================================
- Hits         5010     4996      -14     
+ Misses       1323     1308      -15     
+ Partials      461      460       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review July 21, 2025 13:27
@dweindl dweindl requested a review from a team as a code owner July 21, 2025 13:27
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaling is still useful since tools like pyPESTO will use log- priors to automatically work with the parameters on log scale (I hope...). But fine to move that to pyPESTO.

parameterScale no longer exists in PEtab v2.
@dweindl dweindl merged commit eeb18ac into PEtab-dev:main Jul 22, 2025
7 checks passed
@dweindl dweindl deleted the v2_rm_pscale branch July 22, 2025 04:12
@dweindl dweindl self-assigned this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants