Skip to content

EKF2: migrate params to YAML#22982

Merged
dagar merged 3 commits into
mainfrom
pr-migrate-c-params
Apr 16, 2024
Merged

EKF2: migrate params to YAML#22982
dagar merged 3 commits into
mainfrom
pr-migrate-c-params

Conversation

@bresch
Copy link
Copy Markdown
Member

@bresch bresch commented Apr 5, 2024

Solved Problem

As we're going to move to a multi-config EKF soon, making several instances of the same parameter would result in copy-pasting if we use the old C param description file.

Solution

Convert old C param file to YAML using script done in #19489

Changelog Entry

For release notes:

New parameter: -
Documentation: -

next steps:

  • rename to "Navigation Filter" (NF)
  • split module.yaml into several param files (1 per aid source)

@bresch bresch added the EKF2 label Apr 5, 2024
@bresch bresch requested a review from dagar April 5, 2024 10:09
@bresch bresch self-assigned this Apr 5, 2024
@bresch
Copy link
Copy Markdown
Member Author

bresch commented Apr 11, 2024

@dagar those are the diffs in parameters.xml. I don't really understand why the "reboot required" has now a capital T but it's the same for some other parameters so I don't think it's an issue.

<       <reboot_required>true</reboot_required>

2748c2748
<     <parameter name="EKF2_ACC_B_NOISE" default="3.0e-3" type="FLOAT">
---
>     <parameter name="EKF2_ACC_B_NOISE" default="0.003" type="FLOAT">
2755c2755
<     <parameter name="EKF2_ACC_NOISE" default="3.5e-1" type="FLOAT">
---
>     <parameter name="EKF2_ACC_NOISE" default="0.35" type="FLOAT">
2778c2778
....
3131c3131
<     <parameter name="EKF2_GYR_B_NOISE" default="1.0e-3" type="FLOAT">
---
>     <parameter name="EKF2_GYR_B_NOISE" default="0.001" type="FLOAT">
3138c3138
<     <parameter name="EKF2_GYR_NOISE" default="1.5e-2" type="FLOAT">
---
>     <parameter name="EKF2_GYR_NOISE" default="0.015" type="FLOAT">
3162c3162
<       <reboot_required>true</reboot_required>
---
>       <reboot_required>True</reboot_required>
3203c3203
<     <parameter name="EKF2_MAG_B_NOISE" default="1.0e-4" type="FLOAT">
---
>     <parameter name="EKF2_MAG_B_NOISE" default="0.0001" type="FLOAT">
3221c3221
<     <parameter name="EKF2_MAG_CHK_INC" default="20." type="FLOAT">
---
>     <parameter name="EKF2_MAG_CHK_INC" default="20.0" type="FLOAT">
3248c3248
<       <reboot_required>true</reboot_required>
---
>       <reboot_required>True</reboot_required>
3250c3250
<     <parameter name="EKF2_MAG_E_NOISE" default="1.0e-3" type="FLOAT">
---
>     <parameter name="EKF2_MAG_E_NOISE" default="0.001" type="FLOAT">
3264c3264
<     <parameter name="EKF2_MAG_NOISE" default="5.0e-2" type="FLOAT">
---
>     <parameter name="EKF2_MAG_NOISE" default="0.05" type="FLOAT">
3274c3274
<       <reboot_required>true</reboot_required>
---
....
3640c3640
<     <parameter name="EKF2_WIND_NSD" default="5.0e-2" type="FLOAT">
---
>     <parameter name="EKF2_WIND_NSD" default="0.05" type="FLOAT">

@bresch bresch force-pushed the pr-migrate-c-params branch from 79a6348 to 9be6bd1 Compare April 11, 2024 09:59
@bresch bresch force-pushed the pr-migrate-c-params branch from 9be6bd1 to d53e1bd Compare April 16, 2024 14:58
@dagar dagar merged commit 7a973ed into main Apr 16, 2024
@dagar dagar deleted the pr-migrate-c-params branch April 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants