Remove client secret due to redundancy#4
Open
themihel wants to merge 2 commits into
Open
Conversation
|
Could we merge this? |
|
up ? |
coliff
approved these changes
Aug 24, 2023
devlopersabbir
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in the title, one could remove the client secret as it is not needed anymore if you set the O-Auth Client to Chrome App.
Like you can see, I removed the redundant client secret like it is also proposed in fregante/chrome-webstore-upload#46. Also tested it myself, the access token generation works like before.