Skip to content

Remove client secret due to redundancy #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
themihel wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −15
Open

Remove client secret due to redundancy #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a473c
Remove client secret as it is not needed anymore
themihel Mar 12, 2021
14978d7
Adapt readme to remove client secret
themihel Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ It uses the specified refresh token to generate an access token for uploading.

Your tokens client id

### `client-secret`

Your tokens client secret

### `refresh-token`

Google developer refresh token
Expand All @@ -38,7 +34,6 @@ uses: Klemensas/chrome-extension-upload-action@$VERSION
with:
refresh-token: 'xxxxxxxxxxxxxxxxxxxxxx'
client-id: 'xxxxxxxxxxxxx'
client-secret: 'xxxxxxxxxxxx'
file-name: './extension.zip'
app-id: 'xzc12xzc21cx23'
publish: true
Expand Down
4 changes: 0 additions & 4 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ inputs:
client-id:
description: Token client id
required: true
client-secret:
description: Token client secret
required: true
file-name:
description: Name of zipped target upload file
required: true
Expand All @@ -28,7 +25,6 @@ runs:
args:
- ${{ inputs.refresh-token }}
- ${{ inputs.client-id }}
- ${{ inputs.client-secret }}
- ${{ inputs.file-name }}
- ${{ inputs.app-id }}
- ${{ inputs.publish }}
11 changes: 5 additions & 6 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ token=`curl \
-d '{
"refresh_token": "'$1'",
"client_id": "'$2'",
"client_secret": "'$3'",
"grant_type": "refresh_token"
}' \
-X POST \
Expand All @@ -24,8 +23,8 @@ status=`curl \
-H "Authorization: Bearer $token" \
-H "x-goog-api-version: 2" \
-X PUT \
-T $4 \
-v https://www.googleapis.com/upload/chromewebstore/v1.1/items/$5 \
-T $3 \
-v https://www.googleapis.com/upload/chromewebstore/v1.1/items/$4 \
| \
jq -r '.uploadState'`

Expand All @@ -34,7 +33,7 @@ then
exit 1
fi

if [ $6 == true ] #publish
if [ $5 == true ] #publish
then
publish=`curl \
--silent \
Expand All @@ -43,8 +42,8 @@ then
-H "Authorization: Bearer $token" \
-H "x-goog-api-version: 2" \
-X POST \
-T $4 \
-v https://www.googleapis.com/upload/chromewebstore/v1.1/items/$5/publish \
-T $3 \
-v https://www.googleapis.com/upload/chromewebstore/v1.1/items/$4/publish \
-d publishTarget=default \
| \
jq -r '.publishState'`
Expand Down