fix: snapshot lastModified before sort in TelegramCacheManager#1899
Merged
theovilardo merged 1 commit intoMay 4, 2026
Merged
Conversation
Reading file.lastModified() inside the comparator lambda on every pairwise comparison lets a concurrent setLastModified() call change the value mid-sort, breaking TimSort's transitivity requirement and crashing with 'Comparison method violates its general contract!'. Snapshot all timestamps into a map before sorting so the comparator sees a stable, immutable view — the same fix applied to AlbumArtCacheManager in an earlier commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TelegramCacheManager.trimEmbeddedArtCache()sorted embedded art files with:embeddedArtFiles.sortBy { it.lastModified() }File.lastModified()is called for every pairwise comparison during the sort. If a concurrent coroutine touches any of those files (e.g. a Telegram thumbnail download callingsetLastModified()), the same file can return a different timestamp in a later comparison — breaking TimSort's transitivity requirement and crashing with:This is the same root cause as the crash reported in #1886 ("app crash when scanning .lrc"), which occurs during the broad sync sweep that runs album-art caching and Telegram operations in parallel.
Fix
Snapshot all
lastModified()timestamps into an immutable map before entering the sort, so the comparator always sees a stable value:This is exactly the pattern already applied to
AlbumArtCacheManager(snapshotFilesForCleanup).Test plan
IllegalArgumentExceptionin logsCloses #1886