Skip to content

fix: snapshot lastModified before sort in TelegramCacheManager #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theovilardo merged 1 commit into from
May 4, 2026
Merged

fix: snapshot lastModified before sort in TelegramCacheManager #1899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/com/theveloper/pixelplay/data/telegram/TelegramCacheManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,13 @@ class TelegramCacheManager @Inject constructor(
return@launch // Within limits
}

// Sort by last modified (oldest first) for LRU eviction
embeddedArtFiles.sortBy { it.lastModified() }
// Sort by last modified (oldest first) for LRU eviction.
// Snapshot timestamps before sorting — reading lastModified() inside the
// comparator on every pairwise call lets another coroutine's setLastModified()
// change the value mid-sort, violating TimSort's comparator contract and
// throwing "Comparison method violates its general contract!".
val snapshots = embeddedArtFiles.associateWith { it.lastModified() }
embeddedArtFiles.sortWith(compareBy { snapshots[it] })

var deletedCount = 0
for (file in embeddedArtFiles) {
Expand Down
Loading