[apps] Enable Clang-Format for in_hand_scanner

[SunBlack]

No description provided.

[mvieth]

I manually ran the documentation CI to see if there are any new doxygen warnings/errors, but it appears that apps are excluded from doxygen. I wonder if that makes sense, because the apps headers are installed and available e.g. via the apt package

[SunBlack]

I manually ran the documentation CI to see if there are any new doxygen warnings/errors, but it appears that apps are excluded from doxygen. I wonder if that makes sense, because the apps headers are installed and available e.g. via the apt package

I don't see even any reason to deliver the headers for the apps. Maybe it would be even better to split the PCL package into 3 parts: libpcl (only header), libpcl-dev (libpcl + header), pcl-apps (libpcl + apps). But I think this is not topic of this PR here ;-)

[mvieth]

For the parts that are included in the apps library, apparently mainly dominant_plane_segmentation and render_views_tesselated_sphere, it makes sense to deliver the headers and run doxygen. For the point_cloud_editor (and the other apps that are not in apps library) I too currently don't see a reason why the headers should be available. But it could still be good to run doxygen once after these formatting changes to see if the doxygen comments are still valid.
Regarding splitting the PCL package: the current situation is not totally different from what you described: there is a package for each module containing only the module library (e.g. libpcl-filters1.10, libpcl-apps1.10), and there is libpcl-dev containing all the headers (plus some other stuff), and also depending on all individual module library packages.

[mvieth]

LGTM, but we should discuss sometime whether it is correct that the point_cloud_editor headers are installed

[kunaltyagi]

11/27 only

[SunBlack]

@larshg Since the comments are always related to doxygen: I suggest to apply these changes separately, e.g. if someone has time to create a python script to format them automatically (so it can be also checked on the CI).

[larshg]

I guess it was intended for @kunaltyagi, @SunBlack ?

[SunBlack]

Ah well yes, sry^^

[mvieth]

Could you try @kunaltyagi 's doxygen_fixer script from pull request #5085 on your changes here?

[SunBlack]

Could you try @kunaltyagi 's doxygen_fixer script from pull request #5085 on your changes here?

Tried it, but it misses some issues and also add some issue. So I did it now manually by searching for \

PR can be squashed when merging.

[mvieth]

@kunaltyagi Would you review this one again?

[kunaltyagi]

Note to self: check for isnan on x and normal_x looks funky