Remove remains from when tools was part of libraries. #6358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
changed the title
mvieth
reviewed
Oct 7, 2025
| list(APPEND EXT_DEPS rssdk) | ||
| endif() | ||
|
|
||
| PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS}) |
There was a problem hiding this comment.
The EXT_DEPS variable is now empty/undefined here. Is there a reason why vtk is not listed in there?
There was a problem hiding this comment.
Its set in the top in line 6.
There was a problem hiding this comment.
I am not sure what you mean -- in line 6, vtk is passed as the EXT_DEPS parameter of the PCL_SUBSYS_DEPEND macro, but I do not see how that would set the variable EXT_DEPS here.
However, I believe it is correct that vtk is not passed as the EXT_DEPS parameter to PCL_MAKE_PKGCONFIG because there is no file vtk.pc (compare e.g. #5110 ). So it seems to me that the EXT_DEPS parameter should simply be removed from PCL_MAKE_PKGCONFIG?
mvieth
reviewed
Oct 9, 2025
| list(APPEND EXT_DEPS rssdk) | ||
| endif() | ||
|
|
||
| PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS}) |
There was a problem hiding this comment.
Suggested change
| PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS}) | |
| PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.