Skip to content

Remove remains from when tools was part of libraries. #6358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

Remove remains from when tools was part of libraries. #6358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7be93f
Remains from when tools was part of libraries.
larshg Oct 5, 2025
a7d5d9b
Remove EXT_DEPS from PKGConfig call.
larshg Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions visualization/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set(SUBSYS_DESC "Point cloud visualization library")
set(SUBSYS_DEPS common io kdtree geometry search octree)

PCL_SUBSYS_OPTION(build "${SUBSYS_NAME}" "${SUBSYS_DESC}" ON)
PCL_SUBSYS_DEPEND(build NAME ${SUBSYS_NAME} DEPS ${SUBSYS_DEPS} EXT_DEPS vtk OPT_DEPS openni openni2 ensenso davidSDK dssdk rssdk)
PCL_SUBSYS_DEPEND(build NAME ${SUBSYS_NAME} DEPS ${SUBSYS_DEPS} EXT_DEPS vtk)

if(ANDROID)
message("VTK was found, but cannot be compiled for Android. Please use VES instead.")
Expand Down Expand Up @@ -212,27 +212,7 @@ if(HAVE_QVTK)
endif()
endif()

set(EXT_DEPS "")
if(WITH_OPENNI)
list(APPEND EXT_DEPS libopenni)
endif()
if(WITH_OPENNI2)
list(APPEND EXT_DEPS libopenni2)
endif()
if(WITH_ENSENSO)
list(APPEND EXT_DEPS ensenso)
endif()
if(WITH_DAVIDSDK)
list(APPEND EXT_DEPS davidSDK)
endif()
if(WITH_DSSDK)
list(APPEND EXT_DEPS dssdk)
endif()
if(WITH_RSSDK)
list(APPEND EXT_DEPS rssdk)
endif()

PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS})
PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS})

# Install include files
PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}" ${incs})
Expand Down