chore(flags): add more metrics for new flags service #26447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenbarnes
approved these changes
Nov 27, 2024
Contributor
havenbarnes
left a comment
havenbarnes
left a comment
There was a problem hiding this comment.
this seems to have some same diffs as #26444? Mostly focused on the metrics you added, they look great!
Contributor
Author
yeah my b, forgot to change the branch origination. Just updated. |
dmarticus
changed the base branch from
master
to
chore/optimize-new-flags-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags service is almost ready to hit with real traffic but I want to see how the metrics are looking, so I'm adding in some metrics around common access paths, including: