Test/ssrf protection utilities - #2680
Closed
desireddymohithreddy0925 wants to merge 6 commits into
Closed
Conversation
added 3 commits
June 22, 2026 18:08
desireddymohithreddy0925
requested a review
from Priyanshu-byte-coder
as a code owner
June 22, 2026 17:21
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This was referenced Jul 1, 2026
Closed
Closed
Closed
Closed
Closed
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2615
Summary of Changes
Added comprehensive unit tests for the pure utility functions in
src/lib/ssrf-protection.tsusing Vitest. The asyncisSafeUrlfunction is intentionally excluded from these tests as it requires DNS mocking.Details:
Exported Utility Functions:
ipToNumberandisPrivateIPfromsrc/lib/ssrf-protection.tsso they can be explicitly tested without side effects.ipToNumberTests:0.0.0.0and255.255.255.255.NaN.isPrivateIPTests:10.0.0.0/8,172.16.0.0/12,192.168.0.0/16,127.0.0.0/8,169.254.0.0/16).::1,::,fe80:,fc00:,fd00:).::ffff:127.0.0.1flagged as private,::ffff:8.8.8.8flagged as public).validateUrlBasicTests:httpandhttpsURLs pass validation.ftp,data:,javascript:,file:) correctly fail.Impact